Changed Packages

@awanlin here is the new PR for the ACS plugin. You mentioned to ping you when I reopened it since the last one got closed.

Here is the reference to the old one 😄 #2638

Hi @BethGriggs, I reviewed the previous PR so I'll take this one 👍

Hi @maknop, I've triggers the build and it's failed trying to to the yarn install can you look into that please?

Hi @maknop, I've triggers the build and it's failed trying to to the yarn install can you look into that please?

Yes I'll take a look now.

@awanlin where do you see that failure? I wanted to look at the build failure so I can see the logs.

@awanlin where do you see that failure? I wanted to look at the build failure so I can see the logs.

Do you not see this? I'm asking just incase there some issue preventing you from seeing it. You should be able to click on those failed items to see more details.

Here a link to the failure: https://github.com/backstage/community-plugins/actions/runs/13441006388/job/37574597968?pr=2956#step:5:21

I don't know why but I couldn't see the test failures until now. I checked multiple times today. I can see them now though so I'll see what the issue is. Thanks!

So the issue is that it is trying to install @backstage-community/plugin-acs but that doesn't exist yet.. my understanding was that getting that setup was part of the process. Am I missing something there?

I updated the branch and now it's just stuck on this. This is what I was seeing earlier when I didn't see the results of the pipeline runs.

As you have not had anything merged into this repo yet it won't run the CI, each time you push a commit it resets that. Part of the issue is that it looks like you keep updating from main which would also reset the CI.

Okay, I see. So the issue is that it is trying to install @backstage-community/plugin-acs but that doesn't exist yet.. my understanding was that getting that setup was part of the process. Am I missing something there @awanlin?

Actually I think I see the issue. This is in the plugins/acs/package.json:

"backstage": {
    "role": "frontend-plugin",
    "pluginId": "acs",
    "pluginPackages": [
      "@backstage-community/plugin-acs"
    ]
  },

I should remove this I believe. This NPM package doesn't exist yet. I removed this block of code in the package.json and moved the images dir and README.md within the acs plugin dir since I realized it was in the wrong spot 😄

Cool, just pushed up a fix 😄

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

Hi @maknop, as there are still some CI errors to address that will impact the code base I'm going to wait on reviewing until it's green. I will keep an eye on this to approve the build so you aren't stuck in the mean time 👍

Hey @awanlin, I'll go ahead and work through those tomorrow. What all goes into the review once the CI errors are all resolved and everything is green?

One thing I don't really understand is that there are errors in the CI check that weren't from code I specifically wrote but that were populated from the plugin bootstrap command. I basically moved the code of the entire plugin from a different repo that was being worked on into here.

I'm working through the fixes on the code I wrote but this plugin does come up as it should when I run a yarn dev from the workspace root.

@awanlin Could I get another rerun when you have a moment :)

@awanlin Hi! I have progressed further on the CI errors. Would you mind kicking it off again for me please? 😄